chore: retry in-flight transactions on regular sessions when multiplexed sessions encounter UNIMPLEMENTED errors #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
harshachinta
changed the title
harshachinta
changed the title
olavloite
changed the title
olavloite
reviewed
Mar 26, 2025
...r/src/test/java/com/google/cloud/spanner/MultiplexedSessionDatabaseClientMockServerTest.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/com/google/cloud/spanner/MultiplexedSessionDatabaseClientMockServerTest.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/com/google/cloud/spanner/MultiplexedSessionDatabaseClientMockServerTest.java
Show resolved
Hide resolved
olavloite
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when a transaction using a multiplexed session encountered an
UNIMPLEMENTEDerror with the messageTransaction type read_write not supported with multiplexed sessionsfrom the backend, the transaction would fail abruptly without any special handling.This PR introduces handling for this scenario in the
TransactionRunner, where transactions encountering theUNIMPLEMENTEDerror with the messageTransaction type read_write not supported with multiplexed sessionsare automatically retried using a regular session.