Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(do not merge): demo of template files fix #3711

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Mar 26, 2025

BEGIN_COMMIT_OVERRIDE
BEGIN_NESTED_COMMIT
fix(deps): update the Java code generator (gapic-generator-java) to 2.55.2-SNAPSHOT
END_NESTED_COMMIT
END_COMMIT_OVERRIDE

@diegomarquezp diegomarquezp added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 26, 2025
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 26, 2025
Copy link

generated-files-bot bot commented Mar 26, 2025

Warning: This pull request is touching the following templated files:

  • .github/trusted-contribution.yml

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Mar 26, 2025
@diegomarquezp diegomarquezp force-pushed the demo-templates-fix-202503 branch from 6e7a60d to 6fdd7bc Compare March 27, 2025 19:07
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 27, 2025
@suztomo
Copy link
Member

suztomo commented Mar 27, 2025

Can you evaluate the templated, generated files are really needed? Seeing kokoro/nightly/java7.cfg, it seems you haven't checked that.

@diegomarquezp diegomarquezp force-pushed the demo-templates-fix-202503 branch from 6fdd7bc to a7798ca Compare March 28, 2025 16:15
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants