update video_info version to 2.5 which supports Youtube API v3 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we need to setup youtube api keys? |
|
We probably will, but first there are some other issues. It's not working quite well. I think there is still some work to be on video_info. I'll keep you updated. |
|
Actually it seems that we don't need the API keys, because video_info offers scrapers so it's ok to use it as is. But this PR won't solve anything, we will have to wait for more 4 issues of video_thumbnailer to be implemented and then update the version to 2.6. The fix for the #69 is already implemented in video_info master. Cheers |
List of 2.6 features can be found here thibaudgg/video_info#103
0mega
force-pushed
the
update_video_info_gem
branch
from
ce9bf46 to
c529a2b
Compare
|
Issue fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump video_info to 2.6 to solve the issue #69.
It also introduces new functionalities described here