Fix cell menu not showing in non-editable dataframes #10819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- improve html semantics
1 task
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/3aabfec8aef5470c000446ee7a58ff98c928aac3/gradio-5.21.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@3aabfec8aef5470c000446ee7a58ff98c928aac3#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/3aabfec8aef5470c000446ee7a58ff98c928aac3/gradio-client-1.13.1.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/3aabfec8aef5470c000446ee7a58ff98c928aac3/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
|
Thanks @hannahblair nice catch. This indeed fixes the issue, but noticing a strange UI issue where sorting a column increases its width significantly: Screen.Recording.2025-03-17.at.11.28.19.AM.mov |
- fix column widths changing on sort
|
@abidlabs fixed! |
abidlabs
approved these changes
Mar 18, 2025
|
Nice lgtm! |
freddyaboulton
pushed a commit
that referenced
this pull request
Mar 20, 2025
* remove editable condition * - add test - improve html semantics * add changeset * fix test * fix test * - fix test - fix column widths changing on sort * swap e2e for story --------- Co-authored-by: gradio-pr-bot <[email protected]>
freddyaboulton
added a commit
that referenced
this pull request
Mar 21, 2025
* WIP * Fix * roughdraft * Workinig * query params * add changeset * modify * revert * lint * Code * Fix * lint * Add code * Fix * Fix python unit tests * Update `markupsafe` dependency version (#10820) * changes * add changeset * type * add changeset --------- Co-authored-by: gradio-pr-bot <[email protected]> * Adds a watermark parameter to `gr.Chatbot` that is added to copied text (#10814) * changes * add changeset * format' * test * copy * changes * doc * format --------- Co-authored-by: gradio-pr-bot <[email protected]> * Fix gr.load_chat (#10829) * changes * add changeset --------- Co-authored-by: Ali Abid <[email protected]> Co-authored-by: gradio-pr-bot <[email protected]> * Fix typo in docstring of Request class in route_utils.py (#10833) * Fix cell menu not showing in non-editable dataframes (#10819) * remove editable condition * - add test - improve html semantics * add changeset * fix test * fix test * - fix test - fix column widths changing on sort * swap e2e for story --------- Co-authored-by: gradio-pr-bot <[email protected]> * Sketch code generator (#10824) * changes * changes * add changeset * changes * changes * changes * changes * changes * changes * changes --------- Co-authored-by: Ali Abid <[email protected]> Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: Abubakar Abid <[email protected]> * chore: update versions (#10811) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * minor fixes * fix * Add guide * Minor tweaks * Address comments --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: Abubakar Abid <[email protected]> Co-authored-by: aliabid94 <[email protected]> Co-authored-by: Ali Abid <[email protected]> Co-authored-by: Abdesselam Benameur <[email protected]> Co-authored-by: Hannah <[email protected]> Co-authored-by: Gradio PR Bot <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we moved the sort by logic into the cell menu, we didn't remove the editable condition for showing the cell menu button. This fixes that, and adds a test.
Closes: #10817
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.shPlease run these bash scripts to automatically format your code:
bash scripts/format_backend.sh, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh