-
Notifications
You must be signed in to change notification settings - Fork 55
Adding Develocity input actions #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I performed a proper review, I found some minor code issues. So I've requested these be fixed, plus some documentation updates.
Thanks!
@@ -369,3 +369,15 @@ function getBooleanInput(paramName: string, paramDefault = false): boolean { | |||
} | |||
throw TypeError(`The value '${paramValue} is not valid for '${paramName}. Valid values are: [true, false]`) | |||
} | |||
|
|||
function getMaybeBooleanInput(paramName: string): boolean | undefined { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should return a TypeError for any value besides '', 'false' or 'true'. I'll fix this.
Adding Develocity input actions.
If an input is configured in the action, it will generate the environment variable, example:
This configuration will create the environment variables:
Relation variable-input available: