Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in node when mixing sync/async resolvers (backport of #3529) #3576

Closed

Conversation

chrskrchr
Copy link
Contributor

@chrskrchr chrskrchr commented May 11, 2022

This is a backport of #3529 #3651 to the 16.x branch that fixes #3528.

Full credit to @asztal for identifying the fix and submitting the original PR.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 11, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: chrskrchr / name: Chris Karcher (e835b95)

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label May 12, 2022
@molssongroup
Copy link

/easycla

@chrskrchr
Copy link
Contributor Author

@IvanGoncharov - I finally worked through the EasyCLA issues, would you mind taking a look at this PR?

@github-actions
Copy link

Hi @chrskrchr, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@IvanGoncharov
Copy link
Member

@chrskrchr We are still blocked by missing CLA on #3529 and it should be signed first especially since all the code were copied from there.

@chrskrchr
Copy link
Contributor Author

We are still blocked by missing CLA on #3529 and it should be signed first especially since all the code were copied from there.

@IvanGoncharov - at what point would we consider #3529 abandoned? I don't want to prevent @asztal from getting credit for their great fix, but that PR was opened nearly 2 months ago and we'd like to get this fix rolled out to our production service as quickly as possible. (and remove some bandaids we wrapped around the issue to prevent it from causing a process exit)

@chrskrchr
Copy link
Contributor Author

Closing this and re-submitting as a new PR per the guidance in #3651.

@chrskrchr chrskrchr closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants