feat(design): allow aria-labelledby
to be set by the DaffModalService
#2967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
aria-labelledby
is currently determined by thedaffModalTitle
. If a title is not set, there is noaria-labelledby
on the modal.Fixes: #2915
What is the new behavior?
Provide option for user to set a custom
aria-labelledby
in theDaffModalService
. If one is set by the title and a user sets it in the service, it will override what's set by the title.Does this PR introduce a breaking change?
Other information