Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): allow aria-labelledby to be set by the DaffModalService #2967

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Aug 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

aria-labelledby is currently determined by the daffModalTitle. If a title is not set, there is no aria-labelledby on the modal.

Fixes: #2915

What is the new behavior?

Provide option for user to set a custom aria-labelledby in the DaffModalService. If one is set by the title and a user sets it in the service, it will override what's set by the title.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Aug 13, 2024
@xelaint xelaint requested a review from a team as a code owner August 13, 2024 17:20
@xelaint xelaint force-pushed the modal-service-aria-labelledby branch from b8d89e6 to 3f8d8cc Compare August 13, 2024 18:49
@xelaint xelaint merged commit e381532 into develop Aug 13, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Aug 12, 2024
@damienwebdev damienwebdev deleted the modal-service-aria-labelledby branch October 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Allow aria-labelledby to be set by the modal service
1 participant