Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design-land): add missing provideDaffToast provider in root #3380

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Dec 27, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Error in console on the toast page of design-land because it's missing the daffProvideToast provider that was removed in #3143

Fixes: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint requested a review from a team as a code owner December 27, 2024 19:41
@damienwebdev damienwebdev changed the title fix(design-land): add missing provideDaffToast provider inn root fix(design-land): add missing provideDaffToast provider in root Dec 27, 2024
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 845d490 into develop Dec 27, 2024
4 checks passed
@gray-bot gray-bot mentioned this pull request Dec 26, 2024
@damienwebdev damienwebdev deleted the design-land-provide-toast branch February 20, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants