Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): fix sticky element positioning by updating sidebar viewport overflow for opened over/under sidebars #3452

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 17, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Sticky elements within the viewport are not positioned correctly when a sidebar is opened.
Fixes: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint requested a review from a team as a code owner January 17, 2025 15:35
@xelaint xelaint merged commit 3f35296 into develop Jan 17, 2025
13 checks passed
@gray-bot gray-bot mentioned this pull request Jan 17, 2025
leozhang14 pushed a commit to leozhang14/daffodil that referenced this pull request Feb 9, 2025
@damienwebdev damienwebdev deleted the sidebar-viewport-sticky-fix branch February 20, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant