Skip to content

Don't scale small icons when theme has matchSize #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 28, 2023
Merged

Don't scale small icons when theme has matchSize #301

merged 5 commits into from
Feb 28, 2023

Conversation

ericsoderberghp
Copy link
Contributor

@ericsoderberghp ericsoderberghp commented Feb 27, 2023 •
edited
Loading

Some icons, the simpler ones, look better when scaled down if the stroke width is not also scaled. To be backwards compatible, check theme.icon.matchSize via useScaleProps() in selected icons to set vector-effect="non-scaling-stroke"

taysea
taysea reviewed Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@taysea taysea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storybook looks good -- can we add "LinkNext" to the icons that leverage this? Would be helpful for theme refresh.

taysea
taysea approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@taysea taysea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ericsoderberghp ericsoderberghp merged commit d2e20df into master Feb 28, 2023
@ericsoderberghp ericsoderberghp deleted the fix/vector-effect branch February 28, 2023 00:12
This was referenced Mar 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taysea taysea taysea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericsoderberghp @taysea