Skip to content

Modify social icons to latest branding #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Modify social icons to latest branding #323

merged 2 commits into from
Sep 13, 2023

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Sep 11, 2023

Update social icons to latest branding. Pointing this to "NEXT" branch to stage for next major release.

Tested locally in storybook:
Screen Shot 2023-09-11 at 2 39 03 PM
Screen Shot 2023-09-11 at 2 38 58 PM
Screen Shot 2023-09-11 at 2 38 40 PM
Screen Shot 2023-09-11 at 2 38 34 PM
Screen Shot 2023-09-11 at 2 38 28 PM
Screen Shot 2023-09-11 at 2 38 22 PM
Screen Shot 2023-09-11 at 2 38 16 PM
Screen Shot 2023-09-11 at 2 38 06 PM

Screen Shot 2023-09-11 at 2 39 27 PM Screen Shot 2023-09-11 at 2 39 20 PM Screen Shot 2023-09-11 at 2 39 14 PM Screen Shot 2023-09-11 at 2 39 34 PM

Copy link
Collaborator

@halocline halocline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking about timing. Do these make sense to be released in a minor version? How long will it be until we are ready to publish a major version? Seems like there are external dependencies which affect the major version timing? Should we ship these sooner?

@@ -4,7 +4,12 @@ import { StyledIcon } from '../StyledIcon';

const Mail = forwardRef((props, ref) => (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does "Mail" fit the "social icon" theme? Less about a brand and more about the sharing mechanism?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, it does have a specific color on it when I do plain -- so let me confirm with Chris if it was a specific app/company.

If it's just generic, I'd opt for it not having a specified HEX color and not be considered part of this "social icon" set.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I connected with Chris. That "Mail" option is one we have for brand to use alongside other social icons in a "share to" kind of scenario. It is not a specific company icon, so from an open-source standpoint it doesn't necessarily make sense to be grouped with this.

It seems in some of his future revisions for icons, he's exploring a "filled" version of some of the icons so that might make more sense.

Given that discussion, I'm going to remove the modification to this icon for now.

@taysea
Copy link
Collaborator Author

taysea commented Sep 12, 2023

Just thinking about timing. Do these make sense to be released in a minor version? How long will it be until we are ready to publish a major version? Seems like there are external dependencies which affect the major version timing? Should we ship these sooner?

Wasn't sure if shipping these in a minor version would break backwards compatibility semantic versioning rules. It's kind of a blurry line in the sense that they are modified and look different than old logos, but also it's just keeping up to date with external brands and it doesn't feel like we should have to major release each time some other brand changes its logo.

Talking myself into including these in a minor release, but what do you think @halocline @jcfilben

@jcfilben
Copy link
Collaborator

Wasn't sure if shipping these in a minor version would break backwards compatibility semantic versioning rules. It's kind > of a blurry line in the sense that they are modified and look different than old logos, but also it's just keeping up to date > with external brands and it doesn't feel like we should have to major release each time some other brand changes its logo.

Talking myself into including these in a minor release, but what do you think @halocline @jcfilben

I'm comfortable with considering these updates as a minor release

@halocline
Copy link
Collaborator

Wasn't sure if shipping these in a minor version would break backwards compatibility semantic versioning rules. It's kind > of a blurry line in the sense that they are modified and look different than old logos, but also it's just keeping up to date > with external brands and it doesn't feel like we should have to major release each time some other brand changes its logo.
Talking myself into including these in a minor release, but what do you think @halocline @jcfilben

I'm comfortable with considering these updates as a minor release

My thinking is:

  • Functionality is still intact.
  • Part of the icon "service" is to stay up to date with brands. Adjusting the brand's icon is simply passing through something the brand executed. This is different than altering the style for how icons are drawn in general.

So, I'd be okay with the minor.

@taysea taysea changed the base branch from NEXT to master September 12, 2023 22:09
@taysea
Copy link
Collaborator Author

taysea commented Sep 12, 2023

Great, have updated the base branch to master.

@taysea taysea requested a review from halocline September 12, 2023 22:52
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@taysea taysea merged commit ae1b96b into master Sep 13, 2023
@taysea taysea deleted the update-social-icons branch September 13, 2023 16:29
@taysea taysea mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants