Skip to content

Fix bug which blocked support of non-px sizes #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix bug which blocked support of non-px sizes #325

merged 1 commit into from
Sep 22, 2023

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Sep 13, 2023 •
edited
Loading

Fixing bug introduced by #156 which assumed all sizes were px based. This adds back support for rem, em.

Ensured proportions also work for non-square icons
Screen Shot 2023-09-13 at 11 46 40 AM
Screen Shot 2023-09-13 at 11 46 30 AM

Closes #239

jcfilben
jcfilben approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ThorNolan ThorNolan mentioned this pull request Sep 22, 2023
Closed
@halocline halocline merged commit 2c16c9d into master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halocline halocline halocline approved these changes

@jcfilben jcfilben jcfilben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"rem" size unit no longer support?
3 participants
@taysea @halocline @jcfilben