Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parseTimeout to not handle non-second durations #1706

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Change parseTimeout to not handle non-second durations #1706

merged 1 commit into from
Dec 5, 2017

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Nov 30, 2017

Also, rename to parseDuration since it will be used for things other than timeouts in the future.

@dfawley dfawley requested a review from lyuxuan November 30, 2017 23:28
@dfawley dfawley merged commit 4308342 into grpc:master Dec 5, 2017
@dfawley dfawley deleted the retry-new branch December 5, 2017 21:52
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lyuxuan lyuxuan lyuxuan approved these changes

@MakMukhi MakMukhi MakMukhi approved these changes

Assignees

@lyuxuan lyuxuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfawley @lyuxuan @MakMukhi