JUnit ExpectedException is deprecated #7467
Labels
Milestone
Comments
ejona86
added a commit
to ejona86/grpc-java
that referenced
this issue
Jan 13, 2023
ExpectedException is deprecated, so I fixed the new warnings. However, we are still using ExpectedException many places and had previously supressed the warning. See grpc#7467 . I did not fix those existing instances that had suppressed the warning, since it is unrelated to the upgrade and we have been free to fix them at any time since we dropped Java 7.
ejona86
added a commit
that referenced
this issue
Jan 20, 2023
ExpectedException is deprecated, so I fixed the new warnings. However, we are still using ExpectedException many places and had previously supressed the warning. See #7467 . I did not fix those existing instances that had suppressed the warning, since it is unrelated to the upgrade and we have been free to fix them at any time since we dropped Java 7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In JUnit 4.13 ExpectedException is deprecated. The replacement,
assertThrows, is Java 8-centric and would be annoying to use in the short-term. Using try+fail would increase boilerplate and would be worse than just using ExpectedException.We can
@SuppressWarningsfor now, but we should swap to assertThrows (or Truth's variant) in the future once we can use Java 8 in our tests.The text was updated successfully, but these errors were encountered: