Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Include XdsConfig as a CallOption #11968

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Mar 18, 2025

This allows Filters to access the xds configuration for their own processing. From gRFC A83:

This data is available via the XdsConfig attribute introduced in A74.
If the xDS ConfigSelector is not already passing that attribute to the
filters, it will need to be changed to do so.

CC @shivaspeaks, this should be the last part to fully unblock gcp authn filter

This allows Filters to access the xds configuration for their own
processing. From gRFC A83:

> This data is available via the XdsConfig attribute introduced in A74.
> If the xDS ConfigSelector is not already passing that attribute to the
> filters, it will need to be changed to do so.
@ejona86 ejona86 requested a review from larry-safran March 18, 2025 22:20
@ejona86 ejona86 merged commit bc3c764 into grpc:master Mar 19, 2025
16 checks passed
@ejona86 ejona86 deleted the xdsconfig-calloption branch March 19, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants