-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core,stub: Add toString() to ClientCallImpl and GrpcFuture #4401
Conversation
Hmm, looks like this project is being built against Guava version 20.0. pendingToString() was added in 23.0. Are there any plans to bump the Guava version? |
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Updated corp CLA status. |
@groakley, it seems the CLA is still a bit unhappy with you. I think #3961 is a blocker for us going as far as Guava 23. It'll happen, but take a little bit. |
@ejona86 #3961 shouldn't be a blocker for adopting newer versions of guava, since guava has two versions - one for java 8, one for android. https://github.com/google/guava/wiki/Release22#new-android-version Does grpc publish separate targets for android and not-android? |
@charlesmunger, the Android version of Guava uses JDK 7 bytecode. The number of Java 6 users should be low, but it is a prerequisite. |
… method was added in a new version of Guava.
@@ -471,6 +471,11 @@ private void closeObserver(Listener<RespT> observer, Status status, Metadata tra | |||
observer.onClose(status, trailers); | |||
} | |||
|
|||
@Override | |||
public String toString() { | |||
return super.toString() + "method=[" + method + "]"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using Guava MoreObjects.ToStringHelper
instead of harding coding =[]
Ditto.
Commenting again with hopes that I've jumped through the CLA hoops properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you! |
Improves debugging experience with ClientCall instances.
Sent on behalf of @charlesmunger