stub: Only throw on cancellation for streaming responses #7173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
dapengzhang0
reviewed
Jul 1, 2020
| @@ -211,24 +215,26 @@ public void onReady() { | |||
| * @param method an adaptor to the actual method on the service implementation. | |||
| */ | |||
| private static <ReqT, RespT> ServerCallHandler<ReqT, RespT> asyncUnaryRequestCall( | |||
There was a problem hiding this comment.
I feel this method is just adding an annoying redirection. Why not just call new UnaryServerCallHandler<>(method, serverStreaming) directly whenever asyncUnaryRequestCall is called?
There was a problem hiding this comment.
That sounds fine. Do you mind if I do that as a follow-up?
There was a problem hiding this comment.
Actually, let me do it as a pre-refactor, since I was going to let this PR "sit" for us to discuss it in the API meeting.
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Jul 1, 2020
The method did nothing; just inline its contents. Brought up as part of grpc#7173's review.
ejona86
added a commit
that referenced
this pull request
Jul 1, 2020
The method did nothing; just inline its contents. Brought up as part of #7173's review.
|
API review:
|
Unary are far more common than streaming, and we're throwing for unary even though it doesn't help the service. Let's stop doing that. We also stop throwing in onComplete() for all cases, because it doesn't help any service; it doesn't stop the service's processing and isn't even all that informative since the cancellation can happen even after onComplete() is called.
dapengzhang0
approved these changes
Jul 22, 2020
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
The method did nothing; just inline its contents. Brought up as part of grpc#7173's review.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unary are far more common than streaming, and we're throwing for unary even
though it doesn't help the service. Let's stop doing that. We also stop
throwing in onComplete() for all cases, because it doesn't help any service;
it doesn't stop the service's processing and isn't even all that informative
since the cancellation can happen even after onComplete() is called.
This is related to #7172, and the docs there would need to be updated. Whichever is merged last will need to be updated.
Note that I saw it is weird that we call both the cancellation and onError callbacks. We should probably just call onError, but that has a greater chance of "being noticed" so I didn't want it to add risk to this PR.