feat(core): EOA sender validation (EIP-3607) #4849
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
preCheck
functionalityCause
This update enhances security by preventing contract accounts from sending transactions directly, aligning with the EIP-3607 standard. It addresses inconsistencies in sender validation logic within the core module. Notably, staking messages are still exempt from the EOA check, as Harmony permits multisig accounts (which are non-EOAs) to send staking messages.
How to Test
make go-test
to verify all unit tests passgo test -run ^TestPreCheck$ github.com/harmony-one/harmony/core
for the specific unit testNotes:
This PR was based on an earlier version (#4840) but has been updated and cleaned up.