Enhance P2P Layer: Stream Removal Tracking and Cooldown Handling #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the P2P layer by introducing a cooldown mechanism for removed streams. Previously, when a stream was removed, the next peer discovery cycle could reconnect to the same stream immediately, potentially causing issues if the peer was invalid or unsynced. This could prevent our node from fully syncing.
Key Changes
✅ Added
RemovalInfostruct to track the removal timestamp, expiration time, and removal count for each stream.✅ Introduced
RemovalCooldownDuration(default: 60 minutes) to enforce a cooldown period before a removed stream can be reconnected.✅ Updated
streamManager.handleAddStreamto check if a stream was recently removed before allowing reconnection.✅ Ensured removed streams are stored in
removedStreamsand properly marked when removal occurs.✅ Refactored variable names and comments for better clarity and maintainability.