Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: Treat legacy providers as hashicorp or builtin #1081

Merged
merged 4 commits into from
Oct 5, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Oct 5, 2022

This was discovered as part of recent failing benchmarks, although it isn't direct root cause of the fail:

https://github.com/hashicorp/terraform-ls/actions/runs/3187102652/jobs/5198346112

Before

2022-10-05 10 58 57

2022-10-05 11 22 06

After

2022-10-05 10 58 21

2022-10-05 11 22 28

@radeksimko radeksimko added the bug Something isn't working label Oct 5, 2022
@radeksimko radeksimko self-assigned this Oct 5, 2022
@radeksimko radeksimko requested a review from a team as a code owner October 5, 2022 10:01

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This is easier than plumbing logger just for that one log line.
@radeksimko radeksimko changed the title schemas: Treat legacy providers as hashicorp schemas: Treat legacy providers as hashicorp or builtin Oct 5, 2022
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@radeksimko radeksimko merged commit a955302 into main Oct 5, 2022
@radeksimko radeksimko deleted the b-fix-legacy-addr-lookups branch October 5, 2022 17:13
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants