ci: Release binaries via CRT

[dbanck]

This is a result of following the CRT onboarding guide.

TODO

• Have access to cut releases granted to maintainers
• Verify all staged artifacts were built correctly
• Remove onboard-crt as build branch from configs
• https://github.com/hashicorp/linux-packaging/pull/165
• Add release-engineering team to repository

[radeksimko]

I understand this is still a draft - so not all comments may be relevant as you're still working on this and you may have already noticed the same thing, but I hope the early review is still helpful. 🤷🏻‍♂️ 😃

[radeksimko]

LGTM for the most part, I just left some minor in-line comments/questions. Thanks for all your work on this!

[radeksimko]

Is it worth removing the dist directory from gitignore now, that we won't build via GoReleaser there?

terraform-ls/.gitignore

Line 1 in 32d9b33

dist/

[dbanck]

I did the following checks to verify the (most) artifacts:

• terraform-ls_0.31.0-dev_darwin_amd64.zip — ✅ works and has provider schemas
• terraform-ls_0.31.0-dev_windows_amd64.zip — ✅ works and has provider schemas
• terraform-ls_0.31.0-dev_linux_amd64.zip — ✅ works and has provider schemas
• Staged artifacts match published on releases.hashicorp.com/terraform-ls ✅
• File size of rpm and debian packages matches the binary ✅

[radeksimko]

LGTM. 🚢

Some random spot checks confirm the artifacts (as available in Artifactory currently) were built as expected:

gpg --verify terraform-ls_0.31.0-dev_SHA256SUMS.72D7468F.sig terraform-ls_0.31.0-dev_SHA256SUMS
gpg: Signature made Tue 31 Jan 16:07:24 2023 GMT
gpg:                using RSA key 374EC75B485913604A831CC7C820C6D5CD27AB87
gpg: Good signature from "HashiCorp Security (hashicorp.com/security) <[email protected]>" [ultimate]

shasum -a256 -c terraform-ls_0.31.0-dev_SHA256SUMS
terraform-ls_0.31.0-dev_darwin_amd64.zip: OK
terraform-ls_0.31.0-dev_darwin_arm64.zip: OK
terraform-ls_0.31.0-dev_freebsd_386.zip: OK
terraform-ls_0.31.0-dev_freebsd_amd64.zip: OK
terraform-ls_0.31.0-dev_freebsd_arm.zip: OK
terraform-ls_0.31.0-dev_linux_386.zip: OK
terraform-ls_0.31.0-dev_linux_amd64.zip: OK
terraform-ls_0.31.0-dev_linux_arm.zip: OK
terraform-ls_0.31.0-dev_linux_arm64.zip: OK
terraform-ls_0.31.0-dev_openbsd_386.zip: OK
terraform-ls_0.31.0-dev_openbsd_amd64.zip: OK
terraform-ls_0.31.0-dev_solaris_amd64.zip: OK
terraform-ls_0.31.0-dev_windows_386.zip: OK
terraform-ls_0.31.0-dev_windows_amd64.zip: OK
terraform-ls_0.31.0-dev_windows_arm64.zip: OK

codesign -dv --verbose=4 ./terraform-ls
Executable=/Users/radeksimko/Downloads/terraform-ls
Identifier=payload
Format=Mach-O thin (x86_64)
CodeDirectory v=20500 size=163539 flags=0x10000(runtime) hashes=5105+2 location=embedded
VersionPlatform=1
VersionMin=657664
VersionSDK=657664
Hash type=sha256 size=32
CandidateCDHash sha1=c91449e674478803a7dbb843ebb9157c77da769e
CandidateCDHashFull sha1=c91449e674478803a7dbb843ebb9157c77da769e
CandidateCDHash sha256=b8f70d10093725bb3c22e77f94c19f41e0714863
CandidateCDHashFull sha256=b8f70d10093725bb3c22e77f94c19f41e07148638c3b365e4439d3b3db9c3623
Hash choices=sha1,sha256
CMSDigest=12b41989d9fbb031684044c8847f832e48c3e5fad2bfc8beae62306d37ff2bc2
CMSDigestType=2
Executable Segment base=0
Executable Segment limit=19476480
Executable Segment flags=0x1
Page size=4096
CDHash=b8f70d10093725bb3c22e77f94c19f41e0714863
Signature size=9127
Authority=Developer ID Application: Hashicorp, Inc. (D38WU7D763)
Authority=Developer ID Certification Authority
Authority=Apple Root CA
Timestamp=31 Jan 2023 at 15:50:13
Info.plist=not bound
TeamIdentifier=D38WU7D763
Runtime Version=10.9.0
Sealed Resources=none
Internal requirements count=1 size=168

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.