Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove automated milestone closure commenting #1266

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

radeksimko
Copy link
Member

We used to auto-close milestoned by GoReleaser before migrating to CRT, but that rarely worked anyway. The issue is that it cannot comment on a locked issue, which given the cadency of our releases and locking timeout is a common issue bflad/action-milestone-comment#67

In this context and considering that relatively detailed Changelog should be sufficient, we decided we don't need this Action anymore.

@radeksimko radeksimko added the ci Continuous integration/delivery related label Apr 28, 2023
@radeksimko radeksimko requested a review from a team as a code owner April 28, 2023 08:24
@radeksimko radeksimko merged commit 410c012 into main Apr 28, 2023
@radeksimko radeksimko deleted the ci-remove-milestone-closing branch April 28, 2023 08:41
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants