context: Replace RPCContextData with DocumentContext
#1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
commented
Sep 29, 2023
| @@ -38,8 +37,6 @@ func (svc *service) TextDocumentDidOpen(ctx context.Context, params lsp.DidOpenT | |||
| return err | |||
| } | |||
|
|
|||
| ctx = lsctx.WithLanguageId(ctx, params.TextDocument.LanguageID) | |||
There was a problem hiding this comment.
I don't know if there's actually any other method that has the same structure that will benefit from this but given that we already do some unmarshaling prior to passing the request to the handler I assume we may as well unmarshal the LanguageID there instead of here.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we propagate the language ID between job scheduling and execution, which in turn enables #1404 at runtime (and not just in unit tests).
While I am labelling this as a bug, it's a bug that was never surfaced to the user in a release, so it does not need to be mentioned in the Changelog AFAICT.