fix: Avoid validating *.tfvars outside of modules #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
radeksimko
force-pushed
the
b-fix-tfvars-validation
branch
from
5447aad to
cc4613b
Compare
jpogran
reviewed
Oct 6, 2023
Comment on lines
+69
to
74
| if len(mod.ParsedModuleFiles) > 0 { | ||
| // Only validate if this is actually a module | ||
| // as we may come across standalone tfvars files | ||
| // for which we have no context. | ||
| pathCtx.Validators = varsValidators | ||
| } |
jpogran
approved these changes
Oct 6, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reported in hashicorp/vscode-terraform#1574
Prior to this patch we would consider any folder with
*.tfvarsas a module. Users may however place*.tfvarsfiles into folders to be loaded anywhere else. In that case we cannot make any assumptions about those*.tfvarsfiles and hence we cannot validate them.