github: Keep running tests on other platforms upon failure #637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch we would stop running any steps in a matrix job immediately when one of them fails.
For example if a single test fails on Linux, that would cause the Windows and macOS steps to stop. While this is a sensible strategy for cost saving it's sometimes helpful to know whether tests actually fail on other platforms or whether it's platform-dependent failure.
We have already applied conservative timeout to each step and our tests generally don't take very long to finish so the cost saving argument is not as strong here anyway.
Docs: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast