Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Keep running tests on other platforms upon failure #637

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Sep 9, 2021

Prior to this patch we would stop running any steps in a matrix job immediately when one of them fails.

For example if a single test fails on Linux, that would cause the Windows and macOS steps to stop. While this is a sensible strategy for cost saving it's sometimes helpful to know whether tests actually fail on other platforms or whether it's platform-dependent failure.

We have already applied conservative timeout to each step and our tests generally don't take very long to finish so the cost saving argument is not as strong here anyway.

Docs: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast

@radeksimko radeksimko added the ci Continuous integration/delivery related label Sep 9, 2021
@hashicorp-cla
Copy link

hashicorp-cla commented Sep 9, 2021

CLA assistant check
All committers have signed the CLA.

@radeksimko radeksimko requested a review from a team September 9, 2021 10:35
@radeksimko radeksimko merged commit 758be48 into main Sep 10, 2021
@radeksimko radeksimko deleted the ci-fail-fast branch September 10, 2021 15:27
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants