Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Emacs editor #932

Merged
merged 3 commits into from
May 31, 2022
Merged

Update docs for Emacs editor #932

merged 3 commits into from
May 31, 2022

Conversation

psibi
Copy link
Contributor

@psibi psibi commented May 29, 2022

I have been recently improving support for terraform client for lsp-mode. The current documentation isn't quite right as there is no
need to manually register the client.

I'm also linking to the newly written official docs for terraform client for lsp-mode which will be helpful.

I have been recently improving support for terraform client for
lsp-mode. The current documentation isn't quite right as there is no
need to manually register the client.

I'm also linking to the newly written official docs for terraform
client for lsp-mode which will be helpful.
@psibi psibi requested a review from a team as a code owner May 29, 2022 10:19
@hashicorp-cla
Copy link

hashicorp-cla commented May 29, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @psibi
Thank you for the contribution and for improving the Terraform experience for emacs users.

I have left some questions and suggestions in-line.

@radeksimko radeksimko added documentation Improvements or additions to documentation waiting-response labels May 30, 2022
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you for all the edits! 👍🏻

@radeksimko radeksimko merged commit 01a3f1f into hashicorp:main May 31, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants