Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser: Remove brew publishing #942

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jun 7, 2022

We can publish homebrew formulas via internal tooling, which also better fits into the new release pipeline. We already send the SNS notification which has the ability to trigger the publishing.

See also hashicorp/homebrew-tap#174

This also avoids the need for the release tooling to ignore *.rb files as release artifacts in dist folder, which currently cause release failures.

@radeksimko radeksimko added the ci Continuous integration/delivery related label Jun 7, 2022
@radeksimko radeksimko marked this pull request as ready for review June 7, 2022 18:54
@radeksimko radeksimko requested a review from a team as a code owner June 7, 2022 18:54
@radeksimko radeksimko merged commit 0bae981 into main Jun 7, 2022
@radeksimko radeksimko deleted the ci-goreleaser-remove-brew branch June 7, 2022 19:42
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants