Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Consul cluster acceptance test #103

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Fix Consul cluster acceptance test #103

merged 1 commit into from
Apr 15, 2021

Conversation

bcmdarroch
Copy link
Contributor

@bcmdarroch bcmdarroch commented Apr 14, 2021 •
edited
Loading

🛠️ Description

This fixes the Consul acceptance test, which had an incorrect assertion, and adds coverage to the size field.

🏗️ Acceptance tests

  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccConsulCluster'

--- PASS: TestAccConsulCluster (516.53s)
PASS

@bcmdarroch bcmdarroch requested a review from a team April 14, 2021 23:21
@bcmdarroch bcmdarroch self-assigned this Apr 14, 2021
@bcmdarroch bcmdarroch changed the title fix Consul cluster acceptance test Fix Consul cluster acceptance test Apr 15, 2021
@bcmdarroch bcmdarroch merged commit 8e6b32e into main Apr 15, 2021
@bcmdarroch bcmdarroch deleted the fix-consul-tests branch April 15, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaks3 roaks3 roaks3 approved these changes

Assignees

@bcmdarroch bcmdarroch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcmdarroch @roaks3