Adds acceptance tests for datasources for HVN, Consul and Vault clusters #135

lackeyjb · 2021-06-03T20:41:40Z

🛠️ Description

Adds acceptance tests for datasources for HVN, Consul and Vault clusters.

🏗️ Acceptance tests

Are there any feature flags that are required to use this functionality? no
Have you added an acceptance test for the functionality being added? no new functionality
Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/... -v  -timeout 120m
?   	github.com/hashicorp/terraform-provider-hcp/internal/clients	[no test files]
=== RUN   Test_RecommendedVersion
=== RUN   Test_RecommendedVersion/with_a_recommended_version
=== RUN   Test_RecommendedVersion/without_a_recommended_version
--- PASS: Test_RecommendedVersion (0.00s)
    --- PASS: Test_RecommendedVersion/with_a_recommended_version (0.00s)
    --- PASS: Test_RecommendedVersion/without_a_recommended_version (0.00s)
=== RUN   Test_IsValidVersion
=== RUN   Test_IsValidVersion/with_a_valid_version
=== RUN   Test_IsValidVersion/with_an_invalid_version
=== RUN   Test_IsValidVersion/with_no_valid_versions
--- PASS: Test_IsValidVersion (0.00s)
    --- PASS: Test_IsValidVersion/with_a_valid_version (0.00s)
    --- PASS: Test_IsValidVersion/with_an_invalid_version (0.00s)
    --- PASS: Test_IsValidVersion/with_no_valid_versions (0.00s)
=== RUN   Test_VersionsToString
=== RUN   Test_VersionsToString/nil_input
=== RUN   Test_VersionsToString/with_a_recommended_version
=== RUN   Test_VersionsToString/without_a_recommended_version
=== RUN   Test_VersionsToString/no_other_versions_but_recommended
=== RUN   Test_VersionsToString/nil_values
--- PASS: Test_VersionsToString (0.00s)
    --- PASS: Test_VersionsToString/nil_input (0.00s)
    --- PASS: Test_VersionsToString/with_a_recommended_version (0.00s)
    --- PASS: Test_VersionsToString/without_a_recommended_version (0.00s)
    --- PASS: Test_VersionsToString/no_other_versions_but_recommended (0.00s)
    --- PASS: Test_VersionsToString/nil_values (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/consul	(cached)
=== RUN   Test_NormalizeVersion
=== RUN   Test_NormalizeVersion/with_a_prefixed_v
=== RUN   Test_NormalizeVersion/without_a_prefixed_v
--- PASS: Test_NormalizeVersion (0.00s)
    --- PASS: Test_NormalizeVersion/with_a_prefixed_v (0.00s)
    --- PASS: Test_NormalizeVersion/without_a_prefixed_v (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/input	(cached)
=== RUN   TestAccDataSourceConsulCluster
--- PASS: TestAccDataSourceConsulCluster (705.65s)
=== RUN   TestAccDataSourceHvn
--- PASS: TestAccDataSourceHvn (60.51s)
=== RUN   TestAccDataSourceVaultCluster
--- PASS: TestAccDataSourceVaultCluster (857.93s)
=== RUN   Test_linkURL
=== RUN   Test_linkURL/valid_ID
=== RUN   Test_linkURL/missing_organization_ID
=== RUN   Test_linkURL/missing_project_ID
=== RUN   Test_linkURL/missing_resource_type
=== RUN   Test_linkURL/missing_resource_ID
=== RUN   Test_linkURL/missing_Location
--- PASS: Test_linkURL (0.00s)
    --- PASS: Test_linkURL/valid_ID (0.00s)
    --- PASS: Test_linkURL/missing_organization_ID (0.00s)
    --- PASS: Test_linkURL/missing_project_ID (0.00s)
    --- PASS: Test_linkURL/missing_resource_type (0.00s)
    --- PASS: Test_linkURL/missing_resource_ID (0.00s)
    --- PASS: Test_linkURL/missing_Location (0.00s)
=== RUN   Test_parseLinkURL
=== RUN   Test_parseLinkURL/valid_URL
=== RUN   Test_parseLinkURL/missing_project_ID
=== RUN   Test_parseLinkURL/missing_resource_type
=== RUN   Test_parseLinkURL/mismatched_resource_type
=== RUN   Test_parseLinkURL/missing_resource_id
=== RUN   Test_parseLinkURL/missing_a_field
=== RUN   Test_parseLinkURL/too_many_fields_before
=== RUN   Test_parseLinkURL/too_many_fields_after
--- PASS: Test_parseLinkURL (0.00s)
    --- PASS: Test_parseLinkURL/valid_URL (0.00s)
    --- PASS: Test_parseLinkURL/missing_project_ID (0.00s)
    --- PASS: Test_parseLinkURL/missing_resource_type (0.00s)
    --- PASS: Test_parseLinkURL/mismatched_resource_type (0.00s)
    --- PASS: Test_parseLinkURL/missing_resource_id (0.00s)
    --- PASS: Test_parseLinkURL/missing_a_field (0.00s)
    --- PASS: Test_parseLinkURL/too_many_fields_before (0.00s)
    --- PASS: Test_parseLinkURL/too_many_fields_after (0.00s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestAccConsulCluster
--- PASS: TestAccConsulCluster (668.79s)
=== RUN   TestAccConsulSnapshot
--- PASS: TestAccConsulSnapshot (723.84s)
=== RUN   TestAccHvn
--- PASS: TestAccHvn (69.58s)
=== RUN   TestAccVaultClusterAdminToken
--- PASS: TestAccVaultClusterAdminToken (831.21s)
=== RUN   TestAccVaultCluster
--- PASS: TestAccVaultCluster (977.02s)
=== RUN   Test_validateStringNotEmpty
=== RUN   Test_validateStringNotEmpty/valid_string
=== RUN   Test_validateStringNotEmpty/empty_string
--- PASS: Test_validateStringNotEmpty (0.00s)
    --- PASS: Test_validateStringNotEmpty/valid_string (0.00s)
    --- PASS: Test_validateStringNotEmpty/empty_string (0.00s)
=== RUN   Test_validateStringInSlice
=== RUN   Test_validateStringInSlice/contains_the_input_(matches_case)
=== RUN   Test_validateStringInSlice/contains_the_input_(case_invariant)
=== RUN   Test_validateStringInSlice/does_not_contain_the_input
--- PASS: Test_validateStringInSlice (0.00s)
    --- PASS: Test_validateStringInSlice/contains_the_input_(matches_case) (0.00s)
    --- PASS: Test_validateStringInSlice/contains_the_input_(case_invariant) (0.00s)
    --- PASS: Test_validateStringInSlice/does_not_contain_the_input (0.00s)
=== RUN   Test_validateSemVer
=== RUN   Test_validateSemVer/valid_semver_without_prefixed_v
=== RUN   Test_validateSemVer/invalid_semver
=== RUN   Test_validateSemVer/valid_semver_with_prefixed_v
--- PASS: Test_validateSemVer (0.00s)
    --- PASS: Test_validateSemVer/valid_semver_without_prefixed_v (0.00s)
    --- PASS: Test_validateSemVer/invalid_semver (0.00s)
    --- PASS: Test_validateSemVer/valid_semver_with_prefixed_v (0.00s)
=== RUN   Test_validateSlugID
=== RUN   Test_validateSlugID/too_long
=== RUN   Test_validateSlugID/valid_id
=== RUN   Test_validateSlugID/empty_string
=== RUN   Test_validateSlugID/invalid_characters
=== RUN   Test_validateSlugID/too_short
--- PASS: Test_validateSlugID (0.00s)
    --- PASS: Test_validateSlugID/too_long (0.00s)
    --- PASS: Test_validateSlugID/valid_id (0.00s)
    --- PASS: Test_validateSlugID/empty_string (0.00s)
    --- PASS: Test_validateSlugID/invalid_characters (0.00s)
    --- PASS: Test_validateSlugID/too_short (0.00s)
=== RUN   Test_validateDatacenter
=== RUN   Test_validateDatacenter/valid_datacenter
=== RUN   Test_validateDatacenter/empty_string
=== RUN   Test_validateDatacenter/invalid_characters
=== RUN   Test_validateDatacenter/uppercase_characters
=== RUN   Test_validateDatacenter/too_short
=== RUN   Test_validateDatacenter/too_long
--- PASS: Test_validateDatacenter (0.00s)
    --- PASS: Test_validateDatacenter/valid_datacenter (0.00s)
    --- PASS: Test_validateDatacenter/empty_string (0.00s)
    --- PASS: Test_validateDatacenter/invalid_characters (0.00s)
    --- PASS: Test_validateDatacenter/uppercase_characters (0.00s)
    --- PASS: Test_validateDatacenter/too_short (0.00s)
    --- PASS: Test_validateDatacenter/too_long (0.00s)
=== RUN   Test_validateConsulClusterTier
=== RUN   Test_validateConsulClusterTier/valid_tier_lowercase
=== RUN   Test_validateConsulClusterTier/valid_tier_uppercase
=== RUN   Test_validateConsulClusterTier/valid_tier_mixedcase
=== RUN   Test_validateConsulClusterTier/invalid_tier
--- PASS: Test_validateConsulClusterTier (0.00s)
    --- PASS: Test_validateConsulClusterTier/valid_tier_lowercase (0.00s)
    --- PASS: Test_validateConsulClusterTier/valid_tier_uppercase (0.00s)
    --- PASS: Test_validateConsulClusterTier/valid_tier_mixedcase (0.00s)
    --- PASS: Test_validateConsulClusterTier/invalid_tier (0.00s)
=== RUN   Test_validateConsulClusterSize
=== RUN   Test_validateConsulClusterSize/valid_size_mixedcase
=== RUN   Test_validateConsulClusterSize/invalid_tier
=== RUN   Test_validateConsulClusterSize/valid_size
=== RUN   Test_validateConsulClusterSize/valid_size_lowercase
=== RUN   Test_validateConsulClusterSize/valid_size_uppercase
--- PASS: Test_validateConsulClusterSize (0.00s)
    --- PASS: Test_validateConsulClusterSize/valid_size_mixedcase (0.00s)
    --- PASS: Test_validateConsulClusterSize/invalid_tier (0.00s)
    --- PASS: Test_validateConsulClusterSize/valid_size (0.00s)
    --- PASS: Test_validateConsulClusterSize/valid_size_lowercase (0.00s)
    --- PASS: Test_validateConsulClusterSize/valid_size_uppercase (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	4895.504s

bcmdarroch · 2021-06-04T17:38:11Z

internal/provider/data_source_consul_cluster_test.go

+	tier       = "development"
+}
+
+data "hcp_consul_cluster" "test" {


I'm getting a bit concerned about test time. Since we have to create the resource here, maybe we could take this config and add it in a new test step on the resource tests. We'll have to document the pattern/leave comments, but I think it's worthwhile to save test time, since the creation/teardown of these cloud resources takes at least 10 minutes.

HVNs, Consul clusters, and Vault clusters

bcmdarroch

Nice work on these! I've got two suggestions that shouldn't take too long to fix.

bcmdarroch · 2021-06-07T22:28:08Z

internal/provider/resource_consul_cluster_test.go

@@ -105,6 +109,33 @@ func TestAccConsulCluster(t *testing.T) {
 					resource.TestCheckResourceAttrSet(resourceName, "size"),
 				),
 			},
+			{


Two things on each of these tests:

Since we have a few test steps now, it'd be great to add some guidance comments at the beginning of each step. I.e. first step testsCreate, second step tests Import, third step tests Updates, and fourth step tests the datasource. It might even be worth an intro comment at the top explaining that the datasource test is incorporated in the resource test.

To have more separation between the test cases, I'm thinking it'd be worth having two TF configs, one with just the resource and the other adding the data source (which we'd use just in this last step).

When I split the configs up the tests errored out, so I ended up just adding comments to each step in the tests

bcmdarroch · 2021-06-08T18:48:10Z

internal/provider/resource_consul_cluster_test.go

@@ -1,3 +1,5 @@
+// This includes tests against both the resource and the corresponding datasource


thanks for adding these! last thing: can you bump this down to above L33? Same for the others? I don't usually see comments above the package in go so I think this'll be easy to miss.

lackeyjb requested a review from a team June 3, 2021 20:41

bcmdarroch reviewed Jun 4, 2021

View reviewed changes

lackeyjb added 2 commits June 7, 2021 15:05

Adds acceptance tests for data sources

c4d704d

HVNs, Consul clusters, and Vault clusters

Move datasource tests to resource tests to decrease test time

268deea

lackeyjb force-pushed the hcpe-1095-data-source-acc-tests branch from ba2c8e8 to 268deea Compare June 7, 2021 19:05

bcmdarroch reviewed Jun 7, 2021

View reviewed changes

Add comments to explain steps in acc tests with datasources added

191c55f

bcmdarroch reviewed Jun 8, 2021

View reviewed changes

Relocate comments

b3bce89

bcmdarroch approved these changes Jun 8, 2021

View reviewed changes

lackeyjb merged commit 641cd53 into main Jun 10, 2021

lackeyjb deleted the hcpe-1095-data-source-acc-tests branch June 10, 2021 13:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds acceptance tests for datasources for HVN, Consul and Vault clusters #135

Adds acceptance tests for datasources for HVN, Consul and Vault clusters #135

lackeyjb commented Jun 3, 2021

bcmdarroch Jun 4, 2021

bcmdarroch left a comment

bcmdarroch Jun 7, 2021

lackeyjb Jun 8, 2021

bcmdarroch Jun 8, 2021

		@@ -1,3 +1,5 @@
		// This includes tests against both the resource and the corresponding datasource

Adds acceptance tests for datasources for HVN, Consul and Vault clusters #135

Adds acceptance tests for datasources for HVN, Consul and Vault clusters #135

Conversation

lackeyjb commented Jun 3, 2021

🛠️ Description

🏗️ Acceptance tests

bcmdarroch Jun 4, 2021

Choose a reason for hiding this comment

bcmdarroch left a comment

Choose a reason for hiding this comment

bcmdarroch Jun 7, 2021

Choose a reason for hiding this comment

lackeyjb Jun 8, 2021

Choose a reason for hiding this comment

bcmdarroch Jun 8, 2021

Choose a reason for hiding this comment