Vault secondary tier by reference #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmdarroch
reviewed
May 24, 2022
| @@ -100,6 +100,7 @@ func resourceVaultCluster() *schema.Resource { | |||
| ValidateDiagFunc: validateVaultPathsFilter, | |||
| }, | |||
| Optional: true, | |||
| Computed: true, | |||
There was a problem hiding this comment.
Let's drop this change for now!
himran92
approved these changes
May 24, 2022
| @@ -581,6 +581,8 @@ func setVaultClusterResourceData(d *schema.ResourceData, cluster *vaultmodels.Ha | |||
| } else { | |||
| d.Set("paths_filter", nil) | |||
| } | |||
| } else { | |||
| d.Set("paths_filter", nil) | |||
There was a problem hiding this comment.
just for my knowledge: do we need a new test for this or by default as not set for non-replicated cluster ->paths_filter was nil already
There was a problem hiding this comment.
I don't think this requires a new test case, this was just to play it safe and set paths_filter in all circumstances
bcmdarroch
approved these changes
May 24, 2022
added 5 commits
May 24, 2022 14:02
bcmdarroch
force-pushed
the
vault-secondary-tier-by-reference
branch
from
8ad923e to
f4c7a20
Compare
aidan-mundy
pushed a commit
that referenced
this pull request
Sep 8, 2023
* Vault: change tiers of secondaries to reference primaries * Replace strings.EqualFold with ToLower in diff supression funcs * Add 'computed: true' to Vault paths_filter * Update docs with 'make gencheck' * Vault: always set paths_filter and remove 'Computed'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
No new features, just a couple minor improvements
🚢 Release Note
Release note for CHANGELOG:
🏗️ Acceptance tests
Output from acceptance testing: