Vault: enabled metrics_config and audit_log_config for HCP Vault

[andrey-donelli]

🛠️ Description

Add support to metrics and audit log to the HCP Vault resource

🚢 Release Note

Release note for CHANGELOG:

* Vault: enable metrics_config and audit_log_config  [GH-319]

🏗️ Acceptance tests

• Are there any feature flags that are required to use this functionality?
• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

https://user-images.githubusercontent.com/97476714/170169244-73934537-7f0c-4ec6-a8d4-15e5a792955d.png
https://user-images.githubusercontent.com/97476714/170177128-9f341b0b-6bd9-4efd-90ac-568d0bd14dd8.png

$ make testacc TESTARGS='-run=TestAccXXX'
=== RUN   TestGetValidObservabilityConfig
--- PASS: TestGetValidObservabilityConfig (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	0.297s

--- PASS: TestAccVaultCluster (2601.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	2602.156s
...

[hashicorp-cla]

All committers have signed the CLA.

[codergs]

Looks like a port of already approved PR

[bcmdarroch]

Looks great! Just had two comments to address.

I did some local testing to see the impact on existing resources, and everything checks out.

1. Existing Vault cluster

# config
resource "hcp_hvn" "hvn_1" {
  hvn_id         = "hvn-1"
  cloud_provider = "aws"
  region         = "us-west-2"
  cidr_block     = "172.25.16.0/20"
}

resource "hcp_vault_cluster" "c1" {
  cluster_id      = "test-primary"
  hvn_id          = hcp_hvn.hvn_1.hvn_id
  tier            = "plus_small"
  public_endpoint = true

  # metrics_config {
  #   datadog_api_key = "test_datadog"
  #   datadog_region =       "us1"
  # }
  # audit_log_config {
  #   datadog_api_key = "test_datadog"
  #   datadog_region  = "us1"
  # }
}

$ terraform apply
...
hcp_vault_cluster.c1: Creation complete after 5m32s [id=/project/project1/hashicorp.vault.cluster/test-primary]

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

2. Add metrics config

# updated config
resource "hcp_vault_cluster" "c1" {
  cluster_id      = "test-primary"
  hvn_id          = hcp_hvn.hvn_1.hvn_id
  tier            = "plus_small"
  public_endpoint = true

   metrics_config {
     datadog_api_key = "test_datadog"
     datadog_region =       "us1"
   }
   audit_log_config {
     datadog_api_key = "test_datadog"
     datadog_region  = "us1"
   }
}

$ terraform apply
...
hcp_vault_cluster.c1: Modifications complete after 11m25s [id=/project/project1/hashicorp.vault.cluster/test-primary]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

Removing the config works too 😎

[bcmdarroch]

These references are here intentionally as best practice reference. Can you revert the tier changes?

[bcmdarroch]

This might need to go in its own file, like peering_test.go, since I don't think unit tests and acceptance tests will run in the same file.