Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct consul cluster and root token docs #439

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Conversation

crhino
Copy link
Contributor

@crhino crhino commented Jan 12, 2023

Currently, the tokens generated by HCP Consul are never deleted or invalidated by HCP processes.

🛠️ Description

Update consul docs related to #420 .

Is there anything else I need to do to update docs? I see there are markdown files related to them, are those autogenerated?

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

This was just a docs change, so didn't run tests.

Currently, the tokens generated by HCP Consul are never deleted or
invalidated by HCP processes.
@crhino crhino requested a review from a team as a code owner January 12, 2023 14:44
@crhino crhino requested a review from a team January 12, 2023 14:44
Copy link
Contributor

@itsjaspermilan itsjaspermilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Don't forget to run go generate in the root and commit the files that are updated 😄

@crhino crhino merged commit b5aee9d into main Jan 12, 2023
@crhino crhino deleted the cc-3901/terraform-docs branch January 12, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants