Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create App and Secret Resource in Vault Secrets #593

Merged
merged 43 commits into from
Sep 19, 2023
Merged

Create App and Secret Resource in Vault Secrets #593

merged 43 commits into from
Sep 19, 2023

Conversation

AnPucel
Copy link
Contributor

@AnPucel AnPucel commented Sep 13, 2023 •
edited
Loading

🛠️ Description

This is adding a resource for managing an app and managing a secret within Vault Secrets.

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
=== RUN   TestAccVaultSecretsResourceApp
--- PASS: TestAccVaultSecretsResourceApp (10.02s)
=== RUN   TestAccVaultSecretsResourceSecret
--- PASS: TestAccVaultSecretsResourceSecret (10.99s)

@AnPucel AnPucel requested a review from a team as a code owner September 13, 2023 20:27
@AnPucel AnPucel changed the title Create App Resource in Vault Secrets Create App and Secret Resource in Vault Secrets Sep 14, 2023
austinvalle
austinvalle reviewed Sep 14, 2023
View reviewed changes
averche
averche reviewed Sep 18, 2023
View reviewed changes
averche
averche approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't have a lot of context around this repo.

@AnPucel AnPucel merged commit 24628ba into main Sep 19, 2023
@AnPucel AnPucel deleted the anpucel/HVSAppResource branch September 19, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinvalle austinvalle austinvalle left review comments

@dhuckins dhuckins dhuckins approved these changes

@aidan-mundy aidan-mundy aidan-mundy approved these changes

@averche averche averche approved these changes

@mercedesbh mercedesbh Awaiting requested review from mercedesbh mercedesbh was automatically assigned from hashicorp/vault-cloud

@aslamovamir aslamovamir Awaiting requested review from aslamovamir aslamovamir was automatically assigned from hashicorp/vault-cloud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AnPucel @dhuckins @austinvalle @aidan-mundy @averche