Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource/Data-Source: HCP Waypoint Application #794

Merged
merged 18 commits into from
Mar 22, 2024

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Mar 21, 2024

This PR adds support for both a resource and data-source for managing a Waypoint Application. More information on Waypoint Applications can be found here: https://developer.hashicorp.com/hcp/docs/waypoint/template-use

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccWaypoint_Application"
=== RUN   TestAccWaypoint_Application_DataSource_basic
--- PASS: TestAccWaypoint_Application_DataSource_basic (8.16s)
=== RUN   TestAccWaypoint_Application_Template_basic
--- PASS: TestAccWaypoint_Application_Template_basic (4.67s)
=== RUN   TestAccWaypoint_Application_basic
--- PASS: TestAccWaypoint_Application_basic (5.19s)

@catsby catsby added pr/no-changelog Auto-pinning waypoint and removed pr/no-changelog Auto-pinning labels Mar 21, 2024
@catsby catsby marked this pull request as ready for review March 21, 2024 16:23
@catsby catsby requested review from a team as code owners March 21, 2024 16:23
@catsby catsby requested a review from HenryEstberg March 21, 2024 16:23
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but have a question about app template vs template!

@catsby catsby force-pushed the hcp-waypoint-application branch from b6d0df0 to d15e35f Compare March 21, 2024 20:43
Copy link
Contributor

@HenryEstberg HenryEstberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple of minor typos but they're not blocking so I'm approving now. Looks good!

@catsby
Copy link
Contributor Author

catsby commented Mar 22, 2024

@manish-hashicorp if you could please take a look at your earliest convenience we would appreciate that. The waypoint team has already given this PR approval

* main:
  updated documentation
  updated CHANGELOG.md
  HCPIE-1016: Adding and adjusting subcategories for IAM stuff (#797)
  updated documentation
  updated CHANGELOG.md
@catsby catsby merged commit 10246a0 into main Mar 22, 2024
6 checks passed
@catsby catsby deleted the hcp-waypoint-application branch March 22, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants