-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource/Data-Source: HCP Waypoint Application #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but have a question about app template vs template!
Co-authored-by: Joe <[email protected]>
b6d0df0
to
d15e35f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a couple of minor typos but they're not blocking so I'm approving now. Looks good!
Co-authored-by: HenryEstberg <[email protected]>
Co-authored-by: HenryEstberg <[email protected]>
@manish-hashicorp if you could please take a look at your earliest convenience we would appreciate that. The waypoint team has already given this PR approval |
* main: updated documentation updated CHANGELOG.md HCPIE-1016: Adding and adjusting subcategories for IAM stuff (#797) updated documentation updated CHANGELOG.md
This PR adds support for both a resource and data-source for managing a Waypoint Application. More information on Waypoint Applications can be found here: https://developer.hashicorp.com/hcp/docs/waypoint/template-use
🏗️ Acceptance tests
Are there any feature flags that are required to use this functionality?Output from acceptance testing:
$ make testacc TESTARGS="-run=TestAccWaypoint_Application" === RUN TestAccWaypoint_Application_DataSource_basic --- PASS: TestAccWaypoint_Application_DataSource_basic (8.16s) === RUN TestAccWaypoint_Application_Template_basic --- PASS: TestAccWaypoint_Application_Template_basic (4.67s) === RUN TestAccWaypoint_Application_basic --- PASS: TestAccWaypoint_Application_basic (5.19s)