Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code owners for vault secrets and vault #820

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Fix code owners for vault secrets and vault #820

merged 2 commits into from
Apr 19, 2024

Conversation

codergs
Copy link
Contributor

@codergs codergs commented Apr 19, 2024

🛠️ Description

Fix codeowners for vault secrets resources. The last attempt didn't work as expected.

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@codergs codergs marked this pull request as ready for review April 19, 2024 17:00
@codergs codergs requested a review from a team as a code owner April 19, 2024 17:00
@codergs codergs merged commit 822c172 into main Apr 19, 2024
6 checks passed
@codergs codergs deleted the codergs-another-attempt-to-fix-codeowners branch April 19, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoripov aoripov aoripov approved these changes

@delores-hashicorp delores-hashicorp delores-hashicorp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codergs @aoripov @delores-hashicorp