Skip to content

Support ghc-9.12.* #10656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Support ghc-9.12.* #10656

merged 1 commit into from
Dec 22, 2024

Conversation

philderbeast
Copy link
Collaborator

I'm trying out -XMultilineStrings in cabal-testsuite and struck this warning, having installed ghc-9.12.1 with ghcup:

+Warning: Unknown/unsupported 'ghc' version detected (Cabal 3.15.0.0 supports 'ghc' version < 9.12):
/.../.ghcup/bin/ghc is version <GHCVER>

This pull request is the same as #9928 (that adds support for ghc-9.10.*) but bumps the GHC version once more.


Include the following checklist in your PR:

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mikolaj
Copy link
Member

Mikolaj commented Dec 20, 2024

I wonder if this bump is already on branch 3.14, given that cabal-install 3.14.1.0 is a companion release to GHC 9.12.1.

Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I forgot: should we have done this during release time?

@ulysses4ever
Copy link
Collaborator

I forgot: should we have done this during release time?

wow, that may justify 3.14.2...

@ulysses4ever
Copy link
Collaborator

Doesn't seem like 3.14 has this change:

see https://github.com/haskell/cabal/blob/3.14/Cabal/src/Distribution/Simple/GHC.hs and in particular:

-- Cabal currently supports ghc >= 7.0.1 && < 9.12
-- ... and the following odd development version
unless (ghcVersion < mkVersion [9, 12]) $
warn verbosity $
"Unknown/unsupported 'ghc' version detected "
++ "(Cabal "
++ prettyShow cabalVersion
++ " supports 'ghc' version < 9.12): "

@philderbeast
Copy link
Collaborator Author

Label merge+no rebase is necessary when the pull request is from an organisation.

@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Dec 20, 2024
@Kleidukos Kleidukos added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Dec 22, 2024
@mergify mergify bot merged commit e301eb6 into haskell:master Dec 22, 2024
47 checks passed
@geekosaur geekosaur mentioned this pull request Dec 25, 2024
@geekosaur
Copy link
Collaborator

@mergify backport 3.14

Copy link
Contributor

mergify bot commented Dec 25, 2024

backport 3.14

✅ Backports have been created

@mergify mergify bot mentioned this pull request Dec 25, 2024
6 tasks
mergify bot added a commit that referenced this pull request Dec 26, 2024
@geekosaur
Copy link
Collaborator

@mergify backport 3.14.1.1

Copy link
Contributor

mergify bot commented Dec 26, 2024

backport 3.14.1.1

✅ Backports have been created

@mergify mergify bot mentioned this pull request Dec 26, 2024
6 tasks
mergify bot added a commit that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge+no rebase ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants