Set <pkgname_datadir> to an absolute path #10830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheaf
approved these changes
Mar 14, 2025
The test checks that if you change directory when running a test executable that you can still access datafiles.
|
I take it you deem this ready for review, so let me add the label for that. |
Comment on lines
932
to
+934
| addInternalBuildTools | ||
| :: PackageDescription | ||
| :: AbsolutePath (Dir Pkg) | ||
| -> PackageDescription |
There was a problem hiding this comment.
This is a Cabal API change. We can't backport it. Is that right?
There was a problem hiding this comment.
It would be possible to backport by adding a new function instead of modifying the type of the existing one.
Bodigrim
approved these changes
Mar 20, 2025
|
@ulysses4ever I have put up a backport on #10838. I don't plan to make any more changes to the backport, so the person preparing the release can decide what a suitable course of action is and modify that patch or this patch as they deem necessary. |
|
Sounds good, thanks @mpickering ! |
mergify
bot
added
the
ready and waiting
|
Apparently, conflicts prevent a merge. BTW, should this be backported to 3.14? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #10717 points out that the _datadir environment variable
should be set to an absolute path since the test executables may
change directory during their invocation.
This is easily fixed by using the absoluteWorkingDirLBI
function, which was introduced in 027bddf,
Fixes #10717
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.