Fix multi-repl when only building some internal library targets #10841
+75
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpickering don't hesitate to put the needs-review label when you open a PR that you think is ready for review. (I know this may look a little excessive but pragmatically the label sends a Matrix notification that will make the PR more visible.) |
MangoIV
approved these changes
Mar 24, 2025
|
@MangoIV: thank you for the review. Please kindly accept the invite to the cabal, I've just sent you. |
|
@mpickering: would you like to submit this for merging once you made the final tweaks? |
|
@mpickering: a humble ping? |
When combining together --dependency and --promised-dependency flags, we were using `Map.union` in the wrong place. If you had a dependency and promised-dependency from the same package (ie when using an internal library) then the promised dependency wouldn't be taken into account. The fix is straightforward, don't use `Map.union`. First create a list of everything and then create a map using `fromListWith`. Fixes #10775
mergify
bot
added
the
ready and waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When combining together --dependency and --promised-dependency flags, we were using
Map.unionin the wrong place. If you had a dependency and promised-dependency from the same package (ie when using an internal library) then the promised dependency wouldn't be taken into account.The fix is straightforward, don't use
Map.union. First create a list of everything and then create a map usingfromListWith.Fixes #10775
Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: