-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch cabal-install changelog to Markdown #10849
base: master
Are you sure you want to change the base?
Switch cabal-install changelog to Markdown #10849
Conversation
Thanks for the contribution
↑ you might prefer “rebase” to “merge” (keeps commit history cleaner) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
@PraneyaKumar if you don’t already know about the That means the PR will be in a Not doing things manually allows us some more time for people to comment/check the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to modify cabal-install.cabal
and the filename should be ChangeLog.md
so it is consistent with the other changelogs.
Thanks for the feedback! I'll rebase instead of merging to keep the commit history clean. Let me know if there are any other best practices I should follow.
Got it, thanks for the explanation! I’ll keep that in mind for future PRs. Let me know if there's anything else I should adjust before the merge.
Thanks for pointing that out! I have done the necessary changes. |
@PraneyaKumar thanks a lot for you work here! The file name is still incorrect: it should be |
c9a43e1
to
c5a6fde
Compare
This PR switches plain-text changelog file to ChangeLog.md
Fix #10831