Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cabal-install solver config log output #10854

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erikd
Copy link
Member

@erikd erikd commented Mar 26, 2025

Includes:

This is the PR #9541 rebased and fixed to build.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@erikd erikd requested review from mpickering and grayjay March 26, 2025 01:21
@erikd erikd force-pushed the erikd/cosmetic-changes-2 branch 5 times, most recently from e602461 to 8c1868b Compare March 26, 2025 01:53
@ulysses4ever
Copy link
Collaborator

Any chance you could add examples of what the new output looks like? Say, in the PR description.

@erikd erikd force-pushed the erikd/cosmetic-changes-2 branch 4 times, most recently from 90b0ce8 to c8f419c Compare March 26, 2025 03:43
Includes:

* Apply some of @grayjay and @mpickering comments
* Fix haskell#4251

Co-Authored-By: Erik de Castro Lopo <[email protected]>
@erikd erikd force-pushed the erikd/cosmetic-changes-2 branch from c8f419c to 5a2528d Compare March 26, 2025 04:06
@grayjay
Copy link
Collaborator

grayjay commented Mar 27, 2025

I haven't had a chance to look at the code yet, but, if I remember correctly, #9541 was a followup to #9159. Would it make sense to first update and merge #9159?

Comment on lines +106 to +107
-- FIXME: This is not a very robust way to split the package name and version.
-- I should rather retrieve the package name and version from the QPN ...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to break on boot package names like base-4.14.0.0/installed-4.14.0.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, need to fix that.

@erikd
Copy link
Member Author

erikd commented Mar 27, 2025

I haven't had a chance to look at the code yet, but, if I remember correctly, #9541 was a followup to #9159. Would it make sense to first update and merge #9159?

According to this comment this seems like a precursor to #9159 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solver "rejecting" message is too verbose
5 participants