-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor cabal-install solver config log output #10854
base: master
Are you sure you want to change the base?
Conversation
e602461
to
8c1868b
Compare
Any chance you could add examples of what the new output looks like? Say, in the PR description. |
90b0ce8
to
c8f419c
Compare
Includes: * Apply some of @grayjay and @mpickering comments * Fix haskell#4251 Co-Authored-By: Erik de Castro Lopo <[email protected]>
c8f419c
to
5a2528d
Compare
-- FIXME: This is not a very robust way to split the package name and version. | ||
-- I should rather retrieve the package name and version from the QPN ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to break on boot package names like base-4.14.0.0/installed-4.14.0.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, need to fix that.
According to this comment this seems like a precursor to #9159 . |
Includes:
This is the PR #9541 rebased and fixed to build.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significant
in the changelog file.