Skip to content

Fix #9694 Don't imply that Haddock docs exist, when warning not installed #9695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

mpilgrem
Copy link
Collaborator

@mpilgrem mpilgrem commented Feb 4, 2024

Link to issue: #9694

  • Patches conform to the coding conventions. Follows existing code.
  • Any changes that could be relevant to users have been recorded in the changelog. None relevant.
  • The documentation has been updated, if necessary. No update necessary.
  • Manual QA notes have been included. No QA notes needed.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!) No tests required.

@ulysses4ever
Copy link
Collaborator

@mpilgrem we absolutely dropped the ball on this one. Do you want to try to resurrect it?

@mpilgrem mpilgrem force-pushed the fix9694 branch 2 times, most recently from eeb76cd to 971e12a Compare February 26, 2025 23:00
@Mikolaj
Copy link
Member

Mikolaj commented Apr 10, 2025

@mpilgrem: let's rescue this valuable PR! Let me start by rebasing...

@Mikolaj
Copy link
Member

Mikolaj commented Apr 10, 2025

@mergify rebase

Copy link
Contributor

mergify bot commented Apr 10, 2025

rebase

✅ Branch has been successfully rebased

@Mikolaj
Copy link
Member

Mikolaj commented Apr 14, 2025

CI seems fine. Let me rebase again. @mpilgrem: would you like to set the merge_me label?

@Mikolaj
Copy link
Member

Mikolaj commented Apr 14, 2025

@mergify rebase

Copy link
Contributor

mergify bot commented Apr 14, 2025

rebase

✅ Branch has been successfully rebased

@Mikolaj
Copy link
Member

Mikolaj commented Apr 14, 2025

In the interest of saving this PR, let me set the merge label.

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Apr 14, 2025
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Apr 14, 2025
@Mikolaj
Copy link
Member

Mikolaj commented Apr 16, 2025

@mergify reset

Copy link
Contributor

mergify bot commented Apr 16, 2025

reset

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@Mikolaj
Copy link
Member

Mikolaj commented Apr 16, 2025

@mergify refresh

Copy link
Contributor

mergify bot commented Apr 16, 2025

refresh

✅ Pull request refreshed

@Mikolaj
Copy link
Member

Mikolaj commented Apr 16, 2025

Oh, it was still some minutes to reach the 2 days delay. We'll see now if comments reset the delay...

@geekosaur
Copy link
Collaborator

Only if they're on review comments.

@geekosaur
Copy link
Collaborator

Also the "ready and waiting" label's already on it, so that shouldn't matter. I think it has to be re-queued?

@geekosaur
Copy link
Collaborator

@Mergifyio queue

Copy link
Contributor

mergify bot commented Apr 16, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at c2f046b

@geekosaur
Copy link
Collaborator

codeberg.org threw a 502 on changelog.d download…

@mergify mergify bot merged commit c2f046b into master Apr 16, 2025
53 of 54 checks passed
@mergify mergify bot deleted the fix9694 branch April 16, 2025 17:34
@Mikolaj
Copy link
Member

Mikolaj commented Apr 16, 2025

Hmm, apparently changelogs are not a required CI job. @geekosaur: shall we make it required?

@geekosaur
Copy link
Collaborator

Depends on how often this is likely to happen, I guess, although I don't recall seeing it before. Others? @ulysses4ever, @Kleidukos, @ffaf1?

@ulysses4ever
Copy link
Collaborator

I don't remember seeing this error before. I'm pro adding 9it as a required job.

@geekosaur
Copy link
Collaborator

I went ahead and added it.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants