Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4499-support-for-ghc-912x #4517

Draft
wants to merge 46 commits into
base: master
Choose a base branch
from
Draft

4499-support-for-ghc-912x #4517

wants to merge 46 commits into from

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Mar 16, 2025 •
edited
Loading

@soulomoon soulomoon linked an issue Mar 16, 2025 that may be closed by this pull request
Support for GHC-9.12.x? #4499
Open
@soulomoon soulomoon marked this pull request as draft March 16, 2025 06:32
@soulomoon
Copy link
Collaborator Author

soulomoon commented Mar 16, 2025 •
edited
Loading

Since FinderCacheState is not expose anymore, significant change would be needed make mergeEnvs works.
See https://gitlab.haskell.org/ghc/ghc/-/merge_requests/10897
Take the patch from https://gitlab.haskell.org/ghc/head.hackage/-/blob/master/patches/ghcide-2.9.0.0.patch?ref_type=heads and ajust it to the master

soulomoon added 22 commits March 16, 2025 20:18
@soulomoon
cope with lookupCache function for module location
a767490
@soulomoon
ghcide and ghcide-test built
316079c
@soulomoon
remove unused import of rangesOverlap from PluginUtils
f822964
@soulomoon
managed to build in 9.12.2 without SMethod_TextDocumentImplementation
0f5df94
@soulomoon
add os-string dependency to ghcide.cabal
e795722
@soulomoon
update
97178a2
@soulomoon
update ghcide
8721e99
@soulomoon
fix tidyOpenType
8730bf7
@soulomoon
fix SrcSpanAnn
fa0d4de
@soulomoon
fix: enable gotoImplementation handler in GhcIde plugin
58b7a52
@soulomoon
remove index and allow newer
af99f16
@soulomoon
chore: update index-state in cabal.project
9bd6a85
@soulomoon
fix: conditionally allow newer base and ghc versions for GHC 9.12.2
d806855
@soulomoon
fix: update GHC version constraint to allow newer base and ghc versio…
83f5690 
…ns for GHC 9.12.0
@soulomoon
Merge branch 'master' into 4499-support-for-ghc-912x
c0be925
@soulomoon
fix: adjust import statements for compatibility with GHC versioning
39f4368
@soulomoon
fix: restore rnf implementation for LoadedBCOs in GHC 9.5.0+
e7dd3de
@soulomoon
fix: update conditional compilation for GHC version checks
3414636
@soulomoon
fix: simplify import handling for GHC version checks
7c56c86
@soulomoon
fix: remove redundant import for GHC version 9.10.0
5aea80d
@soulomoon
fix: update import statements and remove redundant rangesOverlap func…
4f68484 
…tion
@soulomoon
fix: clean up import statements in PluginUtils.hs
2b16444
@soulomoon soulomoon mentioned this pull request Mar 18, 2025
Open
@soulomoon
Copy link
Collaborator Author

soulomoon commented Mar 18, 2025 •
edited
Loading

Template haskell contribute the most of ghcide failures

@soulomoon
Copy link
Collaborator Author

soulomoon commented Mar 18, 2025 •
edited
Loading

Fixed template haskell for 9.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj Awaiting requested review from michaelpj michaelpj is a code owner

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 is a code owner

@fendor fendor Awaiting requested review from fendor fendor will be requested when the pull request is marked ready for review fendor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for GHC-9.12.x?
1 participant
@soulomoon