Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendFd shouldn't close the fd argument #150

Closed
JohnLato opened this issue Nov 5, 2014 · 2 comments
Closed

sendFd shouldn't close the fd argument #150

JohnLato opened this issue Nov 5, 2014 · 2 comments
Labels

Comments

@JohnLato
Copy link

JohnLato commented Nov 5, 2014

I think most of the time you don't want it closed, and currently there's no way to avoid it.

@kazu-yamamoto
Copy link
Collaborator

@eborden It is easy to implement this by removing closeFd from sendFd. What do you think?

@eborden
Copy link
Collaborator

eborden commented Dec 15, 2017

@kazu-yamamoto It is pretty typical to close the fd after sending. It isn't required or always what you want so it is probably correct to remove closeFd from sendFd. Its inclusion is more of a high level approach, which isn't really the intent in network any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants