Do not closeFd within sendFd #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should use |
It is common to close a file descriptor after sending it, however it is not a required part of the work flow. There are uses for not closing a file descriptor. Closing the file descriptor is too high level of a decision.
kazu-yamamoto
force-pushed
the
dont-close-fd-in-send-fd
branch
from
34bdbc4 to
76d4802
Compare
|
Merged. |
|
This seems like a huge change to slip into the package without so much as a minor version bump! It was added in the transition from 2.6.3.3 to 2.6.3.4 |
|
@glguy Sorry for your inconvenience. |
|
This probably needs to be a major version change, it changes the behavior of an existing function in a nonbackwards-compatible way. Code that uses this function will need to be modified to work after this change. The CPP macros can't even distinguish a change in the 4th component of a version number. |
|
You suggest:
Am I understanding correctly? |
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common to close a file descriptor after sending it, however it is
not a required part of the work flow. There are uses for not closing a
file descriptor. Closing the file descriptor is too high level of a
decision.
Fix for #150