Backport critical fixes to network-2.3 #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look fine. I'm not sure why travis fell on its face on this one. |
|
@eborden because in the 2.3 branch there was no travis script yet! |
|
That'll do it :) |
|
@eborden ...you were optimistic to merge this before the travis script finished :-) |
|
ick, my brain is not screwed on right today. I'll likely have to back this out and re-open this PR. |
|
Ah, @hvr I didn't notice you snuck that travis script in. |
|
np, I'll fix it up; gimme a sec |
|
Fix is being handled here #197 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are critical fixes to the 2.3-branch which fix issues we're seeing on http://matrix.hackage.haskell.org/ for several old packages which depend on
network < 2.4directly or indirectly and therefore pick the currently brokennetwork-2.3.2.0release.I've tested this patch from GHC 7.0 through GHC 8.0.
Please upload a
network-2.3.2.1release to Hackage soon so that install-plans affected are restored/cc @phadej @bergmark