FreeBSD portability for Control Messages and tests #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Just like Darwin, FreeBSD returns IP_RECVTL, not IP_TTL in the control message when IP_RECVTTL is requested. - Ditto for IP_RECVTOS - FreeBSD does not have IP_PKTINFO - FreeBSD does have IPV6_PKTINFO, but just case don't assume. - The loopback interface on FreeBSD is called lo0, and is not necessarily at index 1. Just make sure that ifNameToIndex and ifIndexToName round-trip without assuming index 1.
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
May 15, 2020
|
Rebased and merged. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
control message when IP_RECVTTL is requested.
necessarily at index 1. Just make sure that ifNameToIndex
and ifIndexToName round-trip without assuming index 1.