Customizable errors for withTransactionModeRetry #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transactions that enter an error state must be aborted manually by issuing a "ROLLBACK". However, if the transaction error happened during a "COMMIT" then the rollback happens automatically. Issuing a "ROLLBACK" at this point causes PostgreSQL to issue a "WARNING: There is no transaction in progress". This warning can have much worse causes (e.g. you "COMMIT" but never began a transaction). This change makes the transaction retrying logic never cause PostgreSQL to issue this warning making it a more useful warning for detecting real bugs.
3noch
commented
May 9, 2020
| mask $ \restore -> | ||
| retryLoop $ E.try $ do | ||
| a <- restore act | ||
| a <- restore act `E.onException` rollback_ conn |
There was a problem hiding this comment.
BTW: Why do we want to use rollback_ here? I don't know why it would be a good idea to ignore exceptions during the rollback.
Also note rollback_ is not exported, but I'm suspicious that it's a good idea in the first place.
3noch
force-pushed
the
eac@customizable-errors-with-transaction-retry
branch
from
e42312a to
509e029
Compare
phadej
reviewed
Nov 15, 2020
|
Merged as part of #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #34