Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Increase instance size used for RHEL tests [DI-435]" #926

Conversation

JackPGreen
Copy link
Collaborator

Reverts #917

Despite testing being unable to reproduce the issue, as soon as merged it failed in the same way as before showing this fix does nothing.

@JackPGreen JackPGreen requested a review from a team as a code owner March 14, 2025 14:11
@JackPGreen JackPGreen enabled auto-merge (squash) March 14, 2025 14:12
@nishaatr
Copy link
Contributor

Why not keep for now, debug further and then see and revert if need be?
This way not need to revert backports for now.
We don't build Docker a lot so should be ok

@JackPGreen
Copy link
Collaborator Author

Why not keep for now, debug further and then see and revert if need be?

This change offers no value to help debug, it was purely to fix:

Waiting for test-13858020706-1-17-hazelcast-enterprise-mancenter-0 pod to be ready
error: timed out waiting for the condition on pods/test-13858020706-1-17-hazelcast-enterprise-mancenter-0

And it hasn't done that.

There's a (small) cost involved with using ubicloud.

This way not need to revert backports for now. We don't build Docker a lot so should be ok

I wasn't planning on reverting the backports due to effort.

@nishaatr
Copy link
Contributor

I wasn't planning on reverting the backports due to effort.

Sure. I will approve.
Ideally (we agreed) to backport changes as it causes headache so we should revert everywhere.
Anyways, not a biggy as branches are out of sync already!

@JackPGreen JackPGreen merged commit 16ecf25 into master Mar 14, 2025
17 checks passed
@JackPGreen JackPGreen deleted the revert-917-Increase-instance-size-used-for-RHEL-tests-DI-435] branch March 14, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants