Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for context classloader issue #58

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Fix for context classloader issue #58

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae3d78c
Moved the initialization of the Hazelcast member instance to the star…
alparslanavci Mar 7, 2019
34f4ea2
Checkstyle fixes
alparslanavci Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions tomcat-core/src/main/java/com/hazelcast/session/HazelcastInstanceFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/*
* Copyright (c) 2008-2016, Hazelcast, Inc. All Rights Reserved.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update to 2019?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkstyle's class header is set as 2016, I needed to keep it as it is to make it pass from the checks. I will send another PR for updating all headers.

*/

package com.hazelcast.session;

import com.hazelcast.client.HazelcastClient;
Expand All @@ -12,8 +16,11 @@
/**
* Factory for {@link HazelcastInstance}'s for session management
*/
public class HazelcastInstanceFactory {
private static final Log log = LogFactory.getLog(HazelcastInstanceFactory.class);
public final class HazelcastInstanceFactory {
private static final Log LOGGER = LogFactory.getLog(HazelcastInstanceFactory.class);

private HazelcastInstanceFactory() {
}

/**
* Gets a {@link HazelcastInstance} by creating a new one (or getting the existing one on P2P setup).
Expand All @@ -33,7 +40,7 @@ public static HazelcastInstance getHazelcastInstance(ClassLoader classLoader, bo
clientConfig.setClassLoader(classLoader);
instance = HazelcastClient.newHazelcastClient(clientConfig);
} catch (Exception e) {
log.error("Hazelcast Client could not be created.", e);
LOGGER.error("Hazelcast Client could not be created.", e);
throw new LifecycleException(e.getMessage());
}
} else if (instanceName != null) {
Expand Down