Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Java version from 11 to 21 #25

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Upgrade Java version from 11 to 21 #25

merged 4 commits into from
Jan 29, 2024

Conversation

mehmettokgoz
Copy link
Contributor

No description provided.

@zhmaeff
Copy link
Contributor

zhmaeff commented Jan 29, 2024

Let's use the latest LTS java we support. (21)

@mehmettokgoz mehmettokgoz changed the title Upgrade Java version from 11 to 17 Upgrade Java version from 11 to 21 Jan 29, 2024
@zhmaeff
Copy link
Contributor

zhmaeff commented Jan 29, 2024

@mehmettokgoz

Depends: default-jdk-headless | java8-sdk-headless
should we change smth in our package files?
I found some fallback to java8

@ldziedziul
Copy link
Contributor

ldziedziul commented Jan 29, 2024

@mehmettokgoz

Depends: default-jdk-headless | java8-sdk-headless

should we change smth in our package files?
I found some fallback to java8

Do not use default-jdk-headless as it point do JDK11 on current ubuntu LTS. Also, you need to change more places, see: https://github.com/hazelcast/hazelcast-packaging/pull/195/files

Copy link
Contributor

@ldziedziul ldziedziul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check how to extract java versions from actions here: https://github.com/hazelcast/hazelcast-packaging/pull/197/files

@zhmaeff zhmaeff merged commit a5672af into master Jan 29, 2024
4 checks passed
@zhmaeff zhmaeff deleted the java-17-upgrade branch January 29, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants